Alex Rivera | Logout

TimeZone.setDefault changes in JDK6

Asked 2010-02-01T13:03:30.950
19

I just noticed that JDK 6 has a different approach to setting a default TimeZone than JDK5.

Previously the new default would be stored in a thread-local variable. With JDK6 (I just reviewed 1.6.0.18) the implementation has changed, so that if the user can write to the "user.timezone" property, or if there is no SecurityManager installed, the timezone changes VM-wide! Otherwise a thread-local change occurs.

Am I wrong? This seems to be quite a drastic change, and I couldn't find anything on the web about it.

Here is the JDK6 code:

 private static boolean hasPermission() {
  boolean hasPermission = true;
  SecurityManager sm = System.getSecurityManager();
  if (sm != null) {
   try {
    sm.checkPermission(new PropertyPermission("user.timezone", "write"));
   } catch (SecurityException e) {
    hasPermission = false;
   }
  }
  return hasPermission;
 }

 /**
  * Sets the <code>TimeZone</code> that is
  * returned by the <code>getDefault</code> method.  If <code>zone</code>
  * is null, reset the default to the value it had originally when the
  * VM first started.
  * @param zone the new default time zone
  * @see #getDefault
  */
 public static void setDefault(TimeZone zone)
 {
  if (hasPermission()) {
   synchronized (TimeZone.class) {
    defaultTimeZone = zone;
    defaultZoneTL.set(null);
   }
  } else {
   defaultZoneTL.set(zone);
  }
 }

while before (in JDK5) it was simply:

 /**
  * Sets the <code>TimeZone</code> that is
  * returned by the <code>getDefault</code> method.  If <code>zone</code>
  * is null, reset the default to the value it had originally when the
  * VM first started.
  * @param zone the new default time zone
  * @see #getDefault
  */
 public static synchronized void setDefault(TimeZone zone)
 {
  defaultZoneTL.set(zone);
 }
Edit
Report

2 Answers

14

Searching the Java Bug Database was actually quite a good idea :)

JDK-6352812 : (tz) REGRESSION: JDK 1.5 TimeZone.setDefault() inconsistent with JDK 1.4 and Mustang

and also (re docs):

JDK-6181786 : (tz) Documentation for TimeZone.getDefault() and TimeZone.setDefault() should clearer

Summary: JDK 1.5 was an exception to the rule, with JDK 1.6 things are back to 'normal', which, according to the docs, is that a timezone change is VM wide.

answered 2010-02-01T14:01:20.663
4

This was probably done to fix a bug. I'd search the Java Bug Database to find the rationale for it. (Clues might also be found in the release notes.)

answered 2010-02-01T13:37:08.850

Your Answer