Edit Question - KnowledgeHub

Title Body

One of my fellow developer has a code similar to the following snippet class Data { public string Prop1 { get { // return the value stored in the database via a query } set { // Save the data to local variable } } public void SaveData() { // Write all the properties to a file } } class Program { public void SaveData() { Data d = new Data(); // Fetch the information from database and fill the local variable d.Prop1 = d.Prop1; d.SaveData(); } } Here the Data class properties fetch the information from DB dynamically. When there is a need to save the Data to a file the developer creates an instance and fills the property using self assignment. Then finally calls a save. I tried arguing that the usage of property is not correct. But he is not convinced. This are his points There are nearly 20 such properties. Fetching all the information is not required except for saving. Instead of self assignment writing an utility method to fetch all will have same duplicate code in the properties. Is this usage correct?

Tags (comma-separated) Cancel