Edit Question - KnowledgeHub

Title Body

I am trying to read all content from a text file. Here is the code which I wrote. #include <stdio.h> #include <stdlib.h> #define PAGE_SIZE 1024 static char *readcontent(const char *filename) { char *fcontent = NULL, c; int index = 0, pagenum = 1; FILE *fp; fp = fopen(filename, "r"); if(fp) { while((c = getc(fp)) != EOF) { if(!fcontent || index == PAGE_SIZE) { fcontent = (char*) realloc(fcontent, PAGE_SIZE * pagenum + 1); ++pagenum; } fcontent[index++] = c; } fcontent[index] = '\0'; fclose(fp); } return fcontent; } static void freecontent(char *content) { if(content) { free(content); content = NULL; } } This is the usage int main(int argc, char **argv) { char *content; content = readcontent("filename.txt"); printf("File content : %s\n", content); fflush(stdout); freecontent(content); return 0; } Since I am new to C, I wonder whether this code looks perfect? Do you see any problems/improvements? Compiler used : GCC. But this code is expected to be cross platform. Any help would be appreciated. Edit Here is the updated code with fread and ftell . static char *readcontent(const char *filename) { char *fcontent = NULL; int fsize = 0; FILE *fp; fp = fopen(filename, "r"); if(fp) { fseek(fp, 0, SEEK_END); fsize = ftell(fp); rewind(fp); fcontent = (char*) malloc(sizeof(char) * fsize); fread(fcontent, 1, fsize, fp); fclose(fp); } return fcontent; } I am wondering what will be the relative complexity of this function?

Tags (comma-separated) Cancel