Edit Question - KnowledgeHub

Title Body

I'm one of those people that has to get their code to compile with 0 warnings. Normally I respect the compiler and if it issues me a warning I take it as a sign that I should touch up my code a little. If I have to tell a compiler to ignore a given warning, I twitch a little. But this one I can't seem to get around, and from what I can tell I haven't done anything "bad". Does anyone think that this is a poor design? I can't see anything particularly nasty about it (except for the "evil diamond") but it's perfectly valid and useful code. But it generates (in MSVC) a level 2 warning! class IFoo { public: virtual void foo() = 0; }; class Bar : public virtual IFoo { public: virtual void foo() { std::cout << "Hello, world!"; } }; class Baz : public virtual IFoo { }; class Quux : public Bar, public Baz { }; Now if I create a Quux object it should be expected to call the Bar::foo implementation. MSVC is very helpful: it warns me for not being ambiguous enough? warning C4250: 'Quux' : inherits 'Bar::Bar::foo' via dominance Now I recognize I can turn this warning off with a pragma, but that's not the question I'm trying to ask here. Is there a reason I should be listening to the compiler here, or is this just an extremely overzealous warning?

Tags (comma-separated) Cancel